I’m a software dev in a small team. I am the most junior member with a couple of years professional experience, but was brought to the (newly formed) team because I had the most hands-on experience with the technology required for the project.
Work has been going well for the past year, but one thing that constantly gets on my nerves is the low-quality code our most senior member commits. I’m personally very strict with code quality and style and always check that all my touched files don’t create new issues with our Linter, StyleCop etc. However, he ignores these mostly. He views it as not important and seemingly wants to focus on function rather than form.
Now I don’t mind if someone checks in a double blank line or a wrongly positioned brace, but empty catch statements, missing null checks or badly named classes are things that shouldn’t go on our main branch, in my opinion. We do not have dedicated code reviews at the moment, and I currently don’t see me in a position to push for them.
I normally have no issues discussing this with my peers (we all make errors, myself included), but I have issues discussing this with him. He has been with the company a lot longer and seems kind of sensitive to discussions about his code. In other words, I don’t want to piss him off, because I like my current job and I’m likely working with him a lot longer. He’s not my superior; we are formally equal.
Should I raise this with my team lead? I’m not sure if I’m just overzealous or too strict here, but considering the product will be very important to our company in the future, I want to strive for quality as early as possible.